Skip to content

chore(docs): ignore nitpicky warnings, drop deprecated setuptools build_sphinx #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

nejch
Copy link
Member

@nejch nejch commented Jun 23, 2022

Closes #1992 by ignoring nitpicky warnings because some will be out of our control anyway (at least without intersphinx).

Drops use of the now-deprecated build_sphinx command. One less config file!

@JohnVillalovos
Copy link
Member

Thanks @nejch

@JohnVillalovos JohnVillalovos merged commit 1c3efb5 into main Jun 24, 2022
@JohnVillalovos JohnVillalovos deleted the docs/deprecated-setuptools branch June 24, 2022 05:04
@kloczek
Copy link

kloczek commented Jun 24, 2022

Swiping warnings under the carpet is not good idea ..

@kloczek
Copy link

kloczek commented Jun 24, 2022

@nejch
Copy link
Member Author

nejch commented Jun 24, 2022

@kloczek please re-open the initial issue if you feel this is important. I'd also appreciate PRs though, as currently I'd rather focus on getting some of our other more important issues into better shape (the CLI and handling complex attributes etc). We can add a help wanted label if that gets people involved as well! :)

Edit: to give some rationale, we already have a lot of very strict linting on the code itself and it seems that beginner contributors give up when CI fails, so this would be another one, but I'm of course happy to merge a proper fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphinx warnings reference target not found
3 participants