Skip to content

PEP 728: Fix minor issues with examples #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

PIG208
Copy link
Contributor

@PIG208 PIG208 commented Jun 29, 2025

Jukka pointed out the incorrect use of extra_items here:
https://discuss.python.org/t/pep-728-typeddict-with-typed-extra-items/45443/157

Also fixed a minor issue with a class missing its body.

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4475.org.readthedocs.build/

Jukka pointed out the incorrect use of extra_items here:
  https://discuss.python.org/t/pep-728-typeddict-with-typed-extra-items/45443/157

Also fixed a minor issue with a class missing its body.
@PIG208 PIG208 requested a review from JelleZijlstra as a code owner June 29, 2025 22:43
@JelleZijlstra JelleZijlstra merged commit e7e5af4 into python:main Jun 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants