gh-136229: Remove Platform Emscripten is not supported warning #136230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
LGTM. Can you also update https://peps.python.org/pep-0011/#tier-3 ?
|
By the way, https://peps.python.org/pep-0776/ is still a draft. |
blockchainGuru1018
approved these changes
Jul 3, 2025
emmatyping
reviewed
Jul 5, 2025
| @@ -1226,9 +1226,10 @@ AS_CASE([$host/$ac_cv_cc_name], | |||
| [s390x-*-linux-gnu/gcc], [PY_SUPPORT_TIER=3], dnl Linux on 64bit s390x (big endian), glibc, gcc | |||
| [x86_64-*-freebsd*/clang], [PY_SUPPORT_TIER=3], dnl FreeBSD on AMD64 | |||
| [aarch64-apple-ios*-simulator/clang], [PY_SUPPORT_TIER=3], dnl iOS Simulator on arm64 | |||
| [aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64 | |||
| [aarch64-apple-ios*/clang], [PY_SUPPORT_TIER=3], dnl iOS on ARM64 | |||
There was a problem hiding this comment.
I think it would be better to indent the other entries more to line up with the line containing aarch64-apple-ios*-simulator/clang (so that all the PY_SUPPORT_TIER lines are aligned)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.