Skip to content

gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180

wants to merge 10 commits into from
+110 −9

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 1, 2025 •
edited by github-actions bot
Loading

Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.

📚 Documentation preview 📚: https://cpython-previews--136180.org.readthedocs.build/

@vstinner
pythongh-135075: Make PyObject_SetAttr() fail with NULL value and exc…
145291d 
…eption

Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called
with NULL value and an exception set.
@vstinner vstinner requested a review from ZeroIntensity as a code owner July 1, 2025 14:26
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2025
Open
@vstinner vstinner mentioned this pull request Jul 1, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

ZeroIntensity
ZeroIntensity reviewed Jul 1, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

serhiy-storchaka
serhiy-storchaka reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Modules/_testcapi/abstract.c is better place than Modules/_testcapi/object.c.

@vstinner
Copy link
Member Author

vstinner commented Jul 2, 2025

I think that Modules/_testcapi/abstract.c is better place than Modules/_testcapi/object.c.

I moved the C code.

serhiy-storchaka
serhiy-storchaka reviewed Jul 2, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@encukou encukou encukou approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @encukou @serhiy-storchaka @ZeroIntensity @blockchainGuru1018