Skip to content

[3.13] gh-135607: remove null checking of weakref list in dealloc of extension modules and objects (#135614) #136126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[3.13] gh-135607: remove null checking of weakref list in dealloc of extension modules and objects (#135614) #136126

merged 1 commit into from
Jul 1, 2025
+75 −73

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 30, 2025 •
edited by bedevere-app bot
Loading

@xuantengh @kumaraditya303 @vstinner
pythongh-135607: remove null checking of weakref list in dealloc of e…
c895571 
…xtension modules and objects (python#135614)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit b1056c2)
This was referenced Jun 30, 2025
Merged
Closed
@vstinner
Copy link
Member Author

I had to fix many merge conflicts for this backport, like on 2/3 of modified files. Please review carefully.

cc @kumaraditya303

kumaraditya303
kumaraditya303 approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vstinner vstinner merged commit e3a277c into python:3.13 Jul 1, 2025
41 checks passed
@vstinner vstinner deleted the weakref_null13 branch July 1, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @kumaraditya303 @xuantengh