Skip to content

gh-90733: improve hashlib.scrypt interface #136100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 29, 2025

  1. scrypt is now unconditionally available so there's no need for this additional define
  2. we actually never exposed scrypt in __all__ so I exposed it
  3. the limits for maxmem and dklen are too restrictive in its current form, but it's also fine in some sense as allowing for a larger maxmem also means removing protections and allowing for VERY large dklen isn't necessary.

@picnixz picnixz force-pushed the fix/hashlib/openssl-scrypt-90733 branch from eb1565c to 0adf063 Compare June 29, 2025 14:30
@picnixz
Copy link
Member Author

picnixz commented Jun 29, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 0adf063 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136100%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants