Skip to content

gh-135755: Use private names (_Py*) for header file guards new in 3.14 #135921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

gh-135755: Use private names (_Py*) for header file guards new in 3.14 #135921

merged 1 commit into from
Jun 26, 2025
+9 −9

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app bot
Loading

These are private; let's name new ones accordingly.

@encukou
pythongh-135755: Use private names (_Py*) for header file guards new …
76adbad 
…in 3.14

These are private API; let's name new ones accordingly.
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
38 tasks
@encukou encukou added skip news needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@encukou encukou merged commit 6be17ba into python:main Jun 26, 2025
45 checks passed
@encukou encukou deleted the private-header-guards branch June 26, 2025 11:05
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@encukou @miss-islington
pythongh-135755: Use private names (_Py*) for header file guards new …
f17714d 
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
(cherry picked from commit 6be17ba)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

GH-135976 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
encukou added a commit that referenced this pull request Jul 1, 2025
@miss-islington @encukou
[3.14] gh-135755: Use private names (_Py*) for header file guards new…
665a682 
… in 3.14 (GH-135921) (GH-135976)

These are private API; let's name new ones accordingly.
(cherry picked from commit 6be17ba)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.14 (tier-1) has failed when building commit 665a682.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1802/builds/251) and take a look at the build logs.
  4. Check if the failure is related to this commit (665a682) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1802/builds/251

Failed tests:

  • test_external_inspection

Failed subtests:

  • test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.14.bolen-ubuntu/build/Lib/test/test_external_inspection.py", line 991, in test_only_active_thread
    self.assertEqual(len(gil_traces), 1, "Should have exactly one GIL holder")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 1 : Should have exactly one GIL holder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @bedevere-bot