Skip to content

gh-135528: Support more second-level domain names in http.cookiejar #135820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −4
Open

gh-135528: Support more second-level domain names in http.cookiejar #135820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17ffb8e
Update cookiejar.py
LamentXU123 Jun 22, 2025
2d72238
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 22, 2025
53c4432
Update 2025-06-22-16-29-10.gh-issue-135528.Rt_QhR.rst
LamentXU123 Jun 22, 2025
6be3c4d
Update 2025-06-22-16-29-10.gh-issue-135528.Rt_QhR.rst
LamentXU123 Jun 22, 2025
9194876
Update cookiejar.py
LamentXU123 Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Lib/http/cookiejar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,13 @@ def set_ok_domain(self, cookie, request):
if j == 0: # domain like .foo.bar
tld = domain[i+1:]
sld = domain[j+1:i]
if sld.lower() in ("co", "ac", "com", "edu", "org", "net",
"gov", "mil", "int", "aero", "biz", "cat", "coop",
"info", "jobs", "mobi", "museum", "name", "pro",
"travel", "eu") and len(tld) == 2:
known_slds = (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add tests for the newly added sld's?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need IMO, the original test script only test .co.uk for this.

Copy link
Contributor Author

@LamentXU123 LamentXU123 Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry to miss that, it actually test [".co.uk", ".org.za", ".tx.us", ".name.us"] but it's just four of them, I think it's still no need to add tests.

"co", "ac", "com", "edu", "org", "net",
"gov", "mil", "int", "aero", "biz", "cat", "coop",
"info", "jobs", "mobi", "museum", "name", "pro",
"travel", "eu", "tv", "or", "nom", "sch", "web",
)
if sld.lower() in known_slds and len(tld) == 2:
# domain like .co.uk
_debug(" country-code second level domain %s", domain)
return False
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-06-22-16-29-10.gh-issue-135528.Rt_QhR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:mod:`http.cookiejar`: add "tv", "or", "nom", "sch", and "web" to the default list of supported country code second-level domains.
Loading