-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-133982: Use implementation-specific open in test_fileio OtherFileTests #135364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is it worth backporting on 3.13? cc @Yhg1s P.S. Congratulations with becoming Core Dev, @ZeroIntensity !!! |
We've been backporting these to 3.13 as far as I can tell. |
Not sure policy: Is a test-only change which enables more testing of The work I'm doing on top of these patches is adding another |
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit e69fba0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135364%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @cmaloney for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…therFileTests` (pythonGH-135364) (cherry picked from commit 23caccf) Co-authored-by: Cody Maloney <[email protected]>
GH-136148 is a backport of this pull request to the 3.14 branch. |
…therFileTests` (pythonGH-135364) (cherry picked from commit 23caccf) Co-authored-by: Cody Maloney <[email protected]>
GH-136149 is a backport of this pull request to the 3.13 branch. |
|
I'm fairly sure that isn't related, especially considering I ran the buildbots beforehand and they were all green. |
Same for me. Lots of segmentation faults and failure to unpack / not enough data across many tests which feels like running out of disk space rather than anything specific around the |
The following build is green. That's strange :-( |
The tests around unicode filenames use both
FileIO
directly andopen
so kept usingopen
for them / validates that unicode filenames passed throughopen()
match behavior ofFileIO
called directly with an encoded name.For the append tests it looks like FileIO directly is closer to what was intended, there is
test_io
that has append tests aroundself.open
directly, this istest_fileio
so intent I think was to test FileIO directly.