Skip to content

gh-88473: Implement fast path in date.today() for date types #130980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-88473: Implement fast path in date.today() for date types #130980

wants to merge 6 commits into from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Mar 8, 2025 •
edited by bedevere-app bot
Loading

Other suggested implementations are not as backward compatible.

$ ./python -m timeit -s 'from datetime import date' 'date.today()'
1000000 loops, best of 5: 271 nsec per loop
$ python3.14 -m timeit -s 'from datetime import date' 'date.today()'
200000 loops, best of 5: 1.36 usec per loop

~5x faster for date types

@bedevere-app bedevere-app bot mentioned this pull request Mar 8, 2025
Open
@picnixz
Copy link
Member

picnixz commented Mar 8, 2025

Are the benchmarks realised on a PGO build or a debug build? or maybe PGO+LTO? or just release build?

@StanFromIreland
Copy link
Member Author

Both are just plain builds. python3.14 is from the morning but I doubt the few commits matter.

picnixz
picnixz reviewed Mar 8, 2025
View reviewed changes
@picnixz
Copy link
Member

picnixz commented Mar 8, 2025

By plain builds, do you mean with or withou --with-pydebug? I assume without so it's probably release builds so it should be fine. But please the configure flags

@StanFromIreland StanFromIreland requested a review from picnixz March 8, 2025 22:06
@StanFromIreland
Copy link
Member Author

@pganssle can you take a look at this?

picnixz
picnixz reviewed Mar 12, 2025
View reviewed changes
@StanFromIreland StanFromIreland requested a review from picnixz March 12, 2025 18:27
picnixz
picnixz approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my part, it looks good but I'll let a datetime expert have the final decision.

@StanFromIreland @picnixz
Benedikt's final nits ;-)
372a764 
Co-authored-by: Bénédikt Tran <[email protected]>
@StanFromIreland
Copy link
Member Author

Friendly ping @pganssle Any comments on this?

@StanFromIreland
Copy link
Member Author

Friendly ping @pganssle :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @picnixz