gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14 #125566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Please add [Doc] label for PR title. like this |
|
What is preferred: or as a prefix for the title without issue #? I used the latter for now. Should it be lowercase too like |
|
In fact, this's just a general behavior, use Doc to mark this PR as documentation. Sorry, I seem to have missed an |
Doc/whatsnew/3.14.rst
Outdated
| @@ -572,7 +572,9 @@ pty | |||
| sqlite3 | |||
| ------- | |||
|
|
|||
| * Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`. | |||
| * Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`; | |||
| use :data:`!sqlite_version` and :data:`!sqlite_version_info` for actual SQLite3 | |||
There was a problem hiding this comment.
These can be linked since they are not removed.
hugovk
reviewed
Jun 28, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 29, 2025
…n What's New 3.14 (pythonGH-125566) (cherry picked from commit 7a403a8) Co-authored-by: fry69 <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-136103 is a backport of this pull request to the 3.14 branch. |
|
@fry69 Thanks for the PR! |
hugovk
added a commit
that referenced
this pull request
Jun 29, 2025
…in What's New 3.14 (GH-125566) (#136103) Co-authored-by: fry69 <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial doc fix to mention the actual SQLite3 version information attributes (I had to look that up, probably others will too)
📚 Documentation preview 📚: https://cpython-previews--125566.org.readthedocs.build/