gh-116093: ABCMeta.__subclasscheck__ now initializes cls if it is not yet initialized #119719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not already initialized
Eclips4
reviewed
May 29, 2024
Eclips4
reviewed
May 29, 2024
Co-authored-by: Kirill Podoprigora <[email protected]>
|
Wanted to +1 this, anything I can do to help it get merged? |
|
Any reason this is blocked? |
|
@ncoghlan Can you help review this PR, as you were the reviewer of the original implementation of |
Made references to methods proper links in news.
|
Hey folks - still hacking around this bug. Anything I can do to help get this moving? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABCMeta.__subclasscheck__now initializes cls if it is not yet initializedThis fixes the issues reported in gh-82266, gh-116093 and gh-119699.
Previously calling
issubclasswithin__init_subclass__may result in the ABC cache of the parent class of the subclass being instantiated to be mutated since the cache of the subclass is not yet initialized.This is fixed by forcing
__subclasscheck__to initialize the current class if it is found to not have been initialized.