Fix a bug in <label> handling where 'for_' attribute should be 'htmlFor' on underlying HTML element.
#2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on underlying HTML element.
WebReflection
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Both good catch and nice call ... there is an historical similar issue in React around class too, not reflected hence pivoted to className which must be explicit ... I feel like camelCased DOM things might be a bit painful to reason about for Python folks, but I wouldn't mind also some conversion such as html_for => htmlFor and class_name => className so that basically most keywords written in snake cases can become automatically valid DOM identifiers ... this is another story though, just worth mentioning (maybe?) my thoughts around these cases (common in most JS libraries too).
|
just wanted to mention that sooner than later, we could have: l = t'<label for{"some-id"}>{"Some text"}</label>'and forget about these cases ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An HTML
labelelement should have aforattribute to reference the id of the form element to which it applies. This is important for accessibility and CSS reasons.Until now, in
pyscript.webyou'd do:Except, this would end up as (note the lack of the
forattribute):😞
The reason for this is because
foris a keyword in both JavaScript and Python. In the HTMLLabelelement class this attribute is actually namedhtmlFor. Hence the lack of thefor_value sinking down to the HTML element.Changes
A very simple mapping of
for->htmlFor, along with updated unit tests to ensure it actually works as expected.Checklist
make buildworks locally.