Add Pyodide lockFileURL test #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe46131 to
c87ee14
Compare
|
In all fairness, this test is not taking into account that saving to the storage the lockfile might add up logic on the second run ... however, this is also good as regression test in general as it's easy to spot when or if the cache is working ... let's see on CI how this goes, I can have dozen OK locally though. |
ntoll
approved these changes
Oct 4, 2024
259efad to
e008036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR adds a test that:
OKas result if the lockFileURL was fasterChanges
Checklist
make buildworks locally.