Replace t.Fatal with require package in tests-e2e #6782
Conversation
|
Could you rebase please? |
|
There are more files left in test/e2e left so I will do it in different PR. One of the files have like 273 appearances so do you want me to have a separate PR for just one file or multiple files in one PR? I am fine both ways. @simonpasquier |
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
|
Hi @AshwinSriram11, looks like there are some conflicts again 😕. Do you mind rebasing the PR? |
Head branch was pushed to by a user without write access
569861e to
72efe8b
Compare
I think I need to rebase it again after your PR #6804 gets merged. |
Correct, sorry for the trouble 😞 |
No problem 🙂 |
72efe8b to
ee1eb2b
Compare
Head branch was pushed to by a user without write access
Description
Continuation to #6749, #6690, #6683, #6680
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.