-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change between v103 and v104 ? #44
Comments
Thanks for the report. Could you provide an example of the syntax you're using to perform the source registration? It would be helpful to know which of the various API surfaces you're encountering this with, e.g. |
Hi @apasel422 , i'm working with @alois-bissuel and i'm able to provide some info about this. Source registration for clicks happen via window.open using the window features (3rd parameter). Here's a real example with the actual
NB: This is called during a click handler function that is dynamically attached (using js) to the link element after DOM is loaded. For displays registrations, we simply have a Thanks for helping, let me know if you need anything else. |
I'm getting an HTTP 400 error when I manually navigate to the
Is there any possibility of providing the URL of a real page on which you're experiencing the discrepancy in endpoint calls? |
Hello @apasel422 and thank you for checking this. The HTTP 400 is "normal", the url is generated for EMEA and won't work from the US or elsewhere. It's working fine for us in Paris. Getting (and sharing) a real publisher page containing a Criteo URL is a bit tricky, "thanks" to the nature of personalized advertising and the multiple layers of intermediate adtechs. @alois-bissuel explained the steps here #38 (comment) I'll try to describe a "canonical" example as best i can. |
Hello @apasel422,
Hope this helps, please don't hesitate to reach out for any further details |
Thanks for the details. CC @johnivdel who knows more about the flag configuration. |
Thanks for the support, |
Thanks for providing the link, able to reproduce this case locally in M104+, will share more information when available, thanks! |
After looking into this on my end, it seems like the browser is trying to parse the attributionsrc= attribute before the origin trial token is added to the page. Could you clarify that the script which adds the token is executed prior the script (or html) which creates the ad? |
Hello @johnivdel, The bug scenario we provided you with tests the integration on the ad web page and shows that we are only loosing displays, reality is that we are loosing both displays and clicks for those specific chrome versions, we found that when being re-targeted by Criteo ads on some publishers (Ad is inside an IFrame) we do not see neither displays nor clicks, could you please help us investigating this ? here are the replication steps:
you will notice that our API is not called for neither clicks nor displays where as it is called for clicks when the ad is loaded as the main web page as here |
Hi @johnivdel Indeed we register the Still we do not see many Can you reproduce the issue on your side? We do not see this issue on the trigger side. EDIT: I looked at the official documentation again and saw that the correct flag for debugging should be chrome://flags/#privacy-sandbox-ads-apis instead.
|
The issue on the demo site is that the origin trial is not enabled in the top-level context. The Permission Policy, similar the the Attribution Reporting API itself, is also gated on the origin trial. The "attribution-reporting" permissions policies cannot be delegated to the ad iframe unless there is a valid OT token within the document embedding the iframe. The documentation you linked does not cover this explicitly, and could probably use updating. |
Thanks for the answer. |
With regard to the first question:
For code to access a trial feature, the browser needs to have (already) seen a token registered for the same origin as the code. So — if you're accessing a feature from an iframe inline in a script element, the browser needs to see a token registered for that origin. If you're including code from an external file (either from the same or a different origin as the iframe) the browser needs a token registered for that origin. If you use a third-party token, make sure that it's provided via an external script, not a meta tag or inline script: see developer.chrome.com/docs/web-platform/origin-trial-troubleshooting/#token-third-script Hope that makes sense. Let me know if it doesn't answer your question! Three demos: |
Thanks @samdutton for the anwser. It makes sense, but I am not sure to fully grasp the intricacies of the interaction between tokens and permissions policy. Would adtech2 be able to use the attribution-reporting API in that case? In the absence of adtech1, I understand that the permission policy |
As an addendum to my question, let's consider the same example, but this time publisher.com uses an SSP (ie an intermediary selling the publisher's advertising space programmatically). This means that adtech's iFrames are embedded within an SSP's iFrame. |
Closing, as I believe it is covered in #52. |
Hello,
We are seeing a lot less calls to our endpoints on the source side for Chrome version 104 and 105 compared to v103. On the trigger side we do not see such a huge imbalance between these three versions.
According to the change log, there has not been any breaking changes in the API for declaring sources (as we do not use
window.RegisterSource
which was deprecated).Furthermore, testing our ads in isolation (ie loading them directly in an empty webpage) in v104 showed no issue (ie the API is correctly called for registering a source and a request to
attributionsrc
is done)This makes us believe the issue might lie in the way the API is enabled or not. Were there any major changes in the way the permissions policies or the token system are handled?
Thanks a lot!
The text was updated successfully, but these errors were encountered: