Skip to content

RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE and LC_* envvars to the server side #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2025
Merged

RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE and LC_* envvars to the server side #187

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5fe166
RemoteOperations::exec_command updated
dmitry-lipetsk Feb 20, 2025
2b1db89
RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE an…
dmitry-lipetsk Feb 20, 2025
4f0ba36
Merge commit '7fd2f07af75391503fb1c79a1bc9ec1f763923af' into D2025022…
dmitry-lipetsk Feb 20, 2025
4eb8330
New tests in TestgresRemoteTests are added
dmitry-lipetsk Feb 21, 2025
f4dc062
TestgresRemoteTests.test_init__unk_LANG_and_LC_CTYPE is updated
dmitry-lipetsk Feb 21, 2025
ee78bcd
Static methods are marked with @staticmethod [thanks to Victoria Shep…
dmitry-lipetsk Feb 21, 2025
5564938
TestRemoteOperations::_quote_envvar is updated (typification)
dmitry-lipetsk Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TestRemoteOperations::_quote_envvar is updated (typification)
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Feb 21, 2025
commit 5564938c8af955f2f6bde67c57ca003d759c94ce
2 changes: 1 addition & 1 deletion testgres/operations/remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def _does_put_envvar_into_exec_cmd(name: str) -> bool:
return False

@staticmethod
def _quote_envvar(value) -> str:
def _quote_envvar(value: str) -> str:
assert type(value) == str # noqa: E721
result = "\""
for ch in value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут лучше append использовать https://www.geeksforgeeks.org/difference-between-and-append-in-python/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Виктория, что-то я не догоняю. Куда тут append использовать?

result - это str. У него нет метода append, но есть поддержка оператора +=, который по смыслу тот же append. Этот += тут и используется.

Copy link
Contributor

@demonolock demonolock Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

типо так


       result = ['"']
        for ch in value:
            if ch == '"':
                result.append('\\"')
            elif ch == '\\':
                result.append('\\\\')
            else:
                result.append(ch)
        result.append('"')
        return ''.join(result)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ага. Не. Не надо нам такой "оптимизации" )

Во первых у нас тут строка. И её элементы могут хранится непрерывно, ну или по крайней мере питон там может как-то оптимизировать это дело. А если будет массив строк - то однозначно каждый элемент массива будет хранится отдельно. Плюс место под сам массив.

А во вторых у нас тут нет оператора сложения. Используется оператор +=.

С append можно заморочится выше - там я три массива складываю через +.

Но честно - если бы эти бестолочи (я про авторов питона) позволяли писать append(list1).append(list2), я бы его заюзал. А так - в топку.

25 лет назад на .NET считалось дурным тоном складывать строки. Юзайте, говорят, StringBuilder. Но потом все дружно на него забили ))

Expand Down