fix for np.float32 serialization #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montanalow
requested changes
Apr 7, 2023
montanalow
approved these changes
Apr 7, 2023
montanalow
reviewed
Apr 7, 2023
pgml-extension/Dockerfile.local
Outdated
| @@ -11,7 +11,7 @@ RUN cat /etc/apt/sources.list | |||
| RUN apt-get update && apt-get install -y postgresql-pgml-14 | |||
|
|
|||
| # Cache this, quicker | |||
| RUN pip3 install xgboost scikit-learn diptest torch lightgbm transformers datasets sentencepiece sentence_transformers sacremoses sacrebleu rouge | |||
| RUN pip3 install xgboost scikit-learn diptest torch lightgbm transformers datasets sentencepiece sentence_transformers sacremoses sacrebleu rouge protobuf | |||
There was a problem hiding this comment.
we should not need protobuf, what requires that?
There was a problem hiding this comment.
Finbert model needs protobuf.
SELECT pgml.transform(
inputs => ARRAY[
'Stocks rallied and the British pound gained.',
'Stocks making the biggest moves midday: Nvidia, Palantir and more'
],
task => '{"task": "text-classification",
"model": "ProsusAI/finbert"
}'::JSONB
) AS market_sentiment;There was a problem hiding this comment.
wow... that's... indicative of a whole new level... are they actually calling any rpcs, or are they just serializing in a round about way? I don't really care...
There was a problem hiding this comment.
I could not reproduce the error I saw before without protobuf on two other machines. I checked the model folder in cache and I don't see any reference to protobuf. Looks like we don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for transforms and moved tune to a different set.