Dan product left nav update #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, add dashbaord styling, fmt, lint
levkk
reviewed
May 10, 2024
| pub mod snapshots; | ||
| pub mod uploader; | ||
|
|
||
| #[get("/deployments")] |
There was a problem hiding this comment.
This conflicts with our cloud route.
There was a problem hiding this comment.
This is not new code, I just moved all the deployment/engine stuff out of lib.rs and into an organized file structure. We add /dashboard to the front. So the actual url is /dashboard/deployments, soon to be /engine/deployments.
There was a problem hiding this comment.
Right, sorry. Been a while since I looked at this code.
chillenberger
added a commit
that referenced
this pull request
May 13, 2024
This reverts commit 5ce41e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback will be added in another PR
Screen.Recording.2024-05-07.at.12.51.38.PM.1.mov