Skip to content

Added vector_search_local #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Added vector_search_local #1387

merged 1 commit into from
Mar 23, 2024

Conversation

SilasMarvin
Copy link
Contributor

No description provided.

@SilasMarvin SilasMarvin merged commit a16ff70 into master Mar 23, 2024
@SilasMarvin SilasMarvin deleted the silas-vector-search-local branch March 23, 2024 22:24
Copy link
Contributor

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case here?

@SilasMarvin
Copy link
Contributor Author

SilasMarvin commented Mar 23, 2024

What's the use case here?

Calling from Rust when the collection and pipeline aren't mutable. For instance, we use the document_search_local in our site. We only need the collection and pipeline to be mutable if we don't know the embeddings are done locally. If the embeddings aren't done locally the query will fail, we update the collection and pipeline with the correct data, and then retry.

@montanalow
Copy link
Contributor

Got it. So, local in this case actually refers to the database, not to the client, as opposed to foreign embeddings from OpenAI, that require a mutable pipeline to implement the retry logic. And we need to query the database find out the local/foreign status of a pipeline, but we're optimistically trying to do it all as a single query. Makes sense.

I think I would've called this native/unified/embedded/inside rather than local, but I get it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants