Skip to content

fix doctype #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix doctype #1300

wants to merge 1 commit into from

Conversation

montanalow
Copy link
Contributor

No description provided.

@montanalow
Copy link
Contributor Author

@chillenberger I see your PR around this too, thought it'd be able to fix than report the missing / in both the regex and url.

@chillenberger
Copy link
Contributor

chillenberger commented Jan 23, 2024

I was thinking about just using the tools from Pathbuf to determine if it is doc, blog, or careers.
let doc_type = match path.strip_prefix(config::cms_dir()) { Ok(path) => { match path.into_iter().next() { Some(dir) => { match &PathBuf::from(dir).display().to_string()[..] { "blog" => Some(DocType::Blog), "docs" => Some(DocType::Docs), "careers" => Some(DocType::Careers), _ => None } }, _ => None } }, _ => None, };
I am working on a pr for this now.

@montanalow
Copy link
Contributor Author

montanalow commented Jan 23, 2024 via email

@chillenberger
Copy link
Contributor

It felt too specific to the doc to put in collection and I wanted to minimize the amount of info the caller needed since I wasn't sure what Silas would have access too. Here is what I am thinking #1301

@montanalow montanalow closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants