-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Comparable helper #5
Labels
back burner
on hold for now
Comments
I have had a similar idea. Quoting from diff.go: // TODO: consider adding an "it just works" test helper that accepts two slices (via interface{}),
// diffs them using Strings or Bytes or Slices (using reflect.DeepEqual) as appropriate,
// and calls t.Errorf with a generated diff if they're not equal. My only hesitation is that it expand the API, and the API already feels kinda large. Let's leave this one on the back burner for a bit until someone has a concrete need for it (I don't yet), since it is easy to add and hard to remove. |
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was just thinking that most of the types one might want to diff can already be compared for equality, as per the language spec.
So, we could add
func Comparable(a, b interface{}) DiffWriteable
. It would ensure that both params are of the same type, that both are slice types, and that both element types are comparable.For example, this would be useful with integers, arrays, custom struct types, et cetera.
I'd still keep
Strings
, because for the foreseeable future, avoiding interface parameters will make the code faster and easier.Potentially, we could also use the
Equal
method as defined in https://github.com/google/go-cmp.The text was updated successfully, but these errors were encountered: