Github App Installation Setup URL does not preserve state query parameter #61291
-
Select Topic AreaBug BodyWe're creating a new Github App with the following expected installation flow:
This is pretty standard oAuth stuff. However, we noticed that when Github redirects to our setup url, it does not preserver the Interestingly if we link the user to the following installation url: https://github.com/apps/sid-quickstart/installations/select_target?state=foo - the Can someone please help or clarify the expected behavior here? |
Beta Was this translation helpful? Give feedback.
Replies: 19 comments 8 replies
-
|
@jamesmartin I've noticed that you've answered similar questions in the past - would you be able to help please? |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this - seeing this behavior pop up just today. Our app installation and oauth flow was working yesterday, but today things are breaking because state is not being returned to our callback. Did something change on Github's end? |
Beta Was this translation helpful? Give feedback.
-
|
+1 as well. Our GitHub apps are not working in production, and is affecting a lot of customers. Would really appreciate a fix asap |
Beta Was this translation helpful? Give feedback.
-
|
+1 GitHub apps are not working and this is negatively affecting our customers! :( |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 affects our prod, any ETA? |
Beta Was this translation helpful? Give feedback.
-
|
Hi Github team, |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
We have migrated to the new |
Beta Was this translation helpful? Give feedback.
-
|
we also made the same fix. |
Beta Was this translation helpful? Give feedback.
-
|
Looks like Github have implemented a 302 redirect from /new to /select_target but failed to pass through the search params. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on Production. |
Beta Was this translation helpful? Give feedback.
-
|
Hey folks, thanks for reporting this. We have a fix in testing right now, about to be deployed. The |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks so much for the update!!! |
Beta Was this translation helpful? Give feedback.
-
|
It's merging now, and I'll ping here when it's fully deployed. |
Beta Was this translation helpful? Give feedback.
-
|
Alright, this is fixed, apologies for the impact here. |
Beta Was this translation helpful? Give feedback.
-
|
This is possibly related to https://github.com/orgs/community/discussions/64239 |
Beta Was this translation helpful? Give feedback.
-
|
Any updates? It seems if the state is took long it wont pass |
Beta Was this translation helpful? Give feedback.
-
|
Seems the problem is back |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
Hey folks, thanks for reporting this. We have a fix in testing right now, about to be deployed. The
select_accountroute is a new endpoint that's internal to the OAuth flow - please don't link to it./newremains the correct endpoint.