BF: groupwise_registration type checking #442
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect type checking in case of numpy arrays. As np.array is just the function to create the array, the type would need to be np.ndarray. If used with a numpy array it results in "typeError: isinstance() arg 2 must be a type or tuple of types" Was used correctly in other cases
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 301 301
Lines 28241 28241
Branches 3286 3286
=======================================
Hits 23509 23509
Misses 3728 3728
Partials 1004 1004
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect type checking in case of numpy arrays. As np.array is just the function to create the array, the type would need to be np.ndarray.
If used with a numpy array it results in "typeError: isinstance() arg 2 must be a type or tuple of types"
Was used correctly in other cases