RF: refactor DCT-II into more visible function #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 83.22% 83.22% -0.01%
==========================================
Files 301 301
Lines 28149 28140 -9
Branches 3279 3278 -1
==========================================
- Hits 23428 23419 -9
Misses 3719 3719
Partials 1002 1002
Continue to review full report at Codecov.
|
|
@bthirion - will the requirement for continuous samples in time be a problem for you? https://github.com/nipy/nipy/pull/417/files#diff-9967264e8820787d766a0f3ee1e4ae67R42 |
|
@jbpoline - any comments? |
Use dedicated function for _cosine basis. This refactoring will require continuous times, otherwise it will raise an error. In any case, I believe that the values returned when times are not continuous are not valid: a) The current function assumes that all differences in volume times are equal to the difference in the first two volume times, and; b) The DCT values should (I believe) reflect the number of `dt` intervals, not the index into the time vector, as currently.
eba5309 to
f3be3ee
Compare
|
Gentlemen - I think the current function will be incorrect when the frametimes are not all equally spaced, do you agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make DCT-II basis an API function, use this function for DCT-II drift in
design_matrix.
@jbpoline - would you mind having a look at this one?