Skip to content

Flip left and right in plot_map. #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

csytracy
Copy link

@csytracy csytracy commented May 6, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 039e2b5 on csytracy:master into 91fddff on nipy:master.

I think this is a better way to do it.
@bthirion
Copy link
Contributor

bthirion commented May 8, 2014

Thanks for the patch. Would you mind explaining a bit the issue that it addresses or the use case, by putting an example, for instance on a gist. Ideally, this would then be translated to a test, so that the behavior is enforced explicitly in the codebase.
Best.

both coronal and axial
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f752fb6 on csytracy:master into 91fddff on nipy:master.

@csytracy
Copy link
Author

csytracy commented May 8, 2014

In the Coronal and Axial view, doctors like to put the right side on the left and the left side on the right. So here I flip the left and right. I think this is also the default setting of AFNI. Different view, such as LPI or RAS, is just a personal choice. I think it will be even better if we can add a parameter to let users choose it. Although I don't think it is a big problem here, I am just offering another choice.

@bthirion
Copy link
Contributor

bthirion commented May 8, 2014

Thanks for clarifying.
All right, this looks like the good old neuroligical/radiological conventions debate. I thinks that it is useful indeed to include an option to also for radiological conventions, but I would keep neurological as a default.
What do people think ?

@matthew-brett
Copy link
Member

I don't know AFNI, but I am sure SPM prefers left-is-left and I believe FSL does too. So, suggested keep left-is-left as default and allow left-is-right as an option.

@matthew-brett
Copy link
Member

Sorry to be slow on this one. @csytracy - would you be interested in making this an option?

@csytracy
Copy link
Author

Maybe I can try. But how would you like it to be? An additional parameter when calling plot_map function?

@matthew-brett
Copy link
Member

Sorry to take so long to get back to you on this one.

Yes, an extra parameter to the plot_map function would be a good option - would you mind having a go?

@matthew-brett
Copy link
Member

Hi - @csytracy - if you are interested to get this done, we could merge it soon, we will probably release in a few days.

@csytracy
Copy link
Author

Sorry, I don't have time to do this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants