Remove node 17 from test workflow, add node 18 #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
kevinsamoei
reviewed
Oct 7, 2022
| @@ -32,7 +32,7 @@ | |||
| "puppeteer": "^18.0.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=14.15 <18" | |||
| "node": ">=14.15 <19" | |||
There was a problem hiding this comment.
I believe there is an issue with running lighthouse v9 on node 18+
The reason we added the <18 was because of that. I am okay with removing 17.x in the workflow file but leave <18 here for that reason
There was a problem hiding this comment.
it might not be a problem anymore - GoogleChrome/lighthouse#13874
I would run lighthouse with node 18 just to make sure
There was a problem hiding this comment.
Good call!
I've just tested using 18.10.0 – running and generating reports is working as expected. I tested the standalone lighthouse module, and again using the netlify plugin.
kevinsamoei
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on the (no longer supported) node 17 is blocking our latest Jest upgrade in #465
Test plan
Check this PR passes its node 18 tests, and didn't run any node 17 ones :)