Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Relay icon tab activation order to *before* the input field #541

Open
Vinnl opened this issue Nov 23, 2023 · 2 comments
Open

Move Relay icon tab activation order to *before* the input field #541

Vinnl opened this issue Nov 23, 2023 · 2 comments

Comments

@Vinnl
Copy link
Collaborator

Vinnl commented Nov 23, 2023 •
edited

Current behaviour:

  • press Tab to focus an email input field
  • press Tab again - the Relay icon gets focus
  • press Tab again - the password input field gets focus

Requested behaviour:

  • press Tab to focus the Relay icon attached to an input field
  • press Tab again to focus the email input field
  • press Tab again to focus the password field

There are two benefits to this:

  1. The Relay icon menu isn't very useful if you've already entered something into the email field.
  2. People have muscle memory of pressing Tab from an email input field to get to the password field.

The downside is that the visual order no longer corresponds with the tab order.

Context: #77 (comment)
@Vinnl Vinnl mentioned this issue Nov 23, 2023
Open
@Vinnl
Copy link
Collaborator Author

Vinnl commented Dec 4, 2023 •
edited

Another report here: https://addons.mozilla.org/en-GB/firefox/addon/private-relay/reviews/2023546/

(Although that person might also already be satisfied by just disabling the icon.)

@onebod
Copy link

onebod commented Mar 25, 2024

I would say desired behaviour: as previously normal and expected -
active field: username,
tab to get to password field.
shift+tab to get to relay icon if it were placed as you suggest - left of username field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vinnl @onebod