-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
rp2/boards/SOLDERPARTY_RP2350_STAMP_XL: Add new Solder Party board. #17001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Greg Dahlman <[email protected]>
Code size report:
|
set(PICO_NUM_GPIOS 48) | ||
|
||
# Board specific version of the frozen manifest | ||
set(MICROPY_FROZEN_MANIFEST ${MICROPY_BOARD_DIR}/manifest.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this if the manifest is the standard one (which it is for this board).
#define MICROPY_HW_USB_MANUFACTURER_STRING "Solder Party" | ||
#define MICROPY_HW_USB_PRODUCT_FS_STRING MICROPY_HW_BOARD_NAME " MicroPython" | ||
|
||
// TODO: Test PSRAM option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSRAM support is now merged to master, so please test it and remove this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The board ships with the PSRAM unpopulated, please advise on if it should be enabled by default? Commit 11f057d seems to suggest so.
Please advise and I will test and update the pull request when I can find the time to solder on a chip and test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
Since the PSRAM can be auto-detected, maybe it can be enabled by default and then hopefully it'll just fallback to using the internal memory if it can't find the PSRAM.
Are you able to test a board without PSRAM installed, but firmware that has PSRAM enabled, and see if it works? Check the output of micropython.mem_info()
.
GP44,GPIO44 | ||
GP45,GPIO45 | ||
GP46,GPIO46 | ||
GP47,GPIO47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is intended to match the silk-screen labels on the PCB. From what I can see the pins are not labelled on the silk screen, so I don't think any of these aliases are needed.
Without a pins.csv, users can still do Pin(1)
and Pin("GPIO1")
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. I was aiming to match the style of other boards in the repo and was concerned about edge cases.
The board only has numbers for a small number of pins. I will remove this file and will update the pull request when the PSRAM comment changes are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I really appreciate your work.
Any chance it will be finished this month?
Thanks a lot.
Summary
Add Solder Party RP2350 Stamp XL board
Testing
Compiled and installed on two Solder Party RP2350 Stamp XL boards.
Performed tests on RP2350B specific GPIO.
Ran tests on NeoPixels, PIO, DMA, and PWM.
Verified USB strings in MacOS system report and Thonny.
Verified mpremote mip install worked.