-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
ports/rp2/boards: Add support for WIZnet-EVB-Pico2 #16280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code size report:
|
6b9334d
to
47049a8
Compare
Signed-off-by: Grace <[email protected]>
Signed-off-by: Grace <[email protected]>
47049a8
to
c907716
Compare
Hi, I notice that in the board definition files, you have defined the external flash size as 16 MByte. However, my understanding was that the flash size is the same as the W5500-EVB-pico, i.e. 2MByte. Also the schematic for the W5500-EVB-Pico2 (see https://docs.wiznet.io/Product/iEthernet/W5500/w5500-evb-pico2#schematic) shows the flash to be a W25Q16JV, a 16Mbit part, i.e 2MByte. |
Signed-off-by: wiznet-grace <[email protected]>
Signed-off-by: wiznet-grace <[email protected]>
8e4b614
to
b443772
Compare
Dear byzantic, Thank you for your advice and for pointing out the issue with the flash size definition. You are absolutely correct, and I sincerely apologize for the oversight. The flash size for the W5500-EVB-Pico2 / W5100S-EVB-Pico2 is indeed 2MByte, as the schematic indicates with the W25Q16JV flash, which is a 2MByte(16Mbit ). I have updated the mpconfigboard.h files to reflect the correct flash size. I truly appreciate your attention to detail and for bringing this to my attention. Thanks again for your help in ensuring the accuracy of the board configuration. Best regards
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some copy & paste minors.
Hopefully this Wiznet Pico2 support will land soon! 👍
"USB" | ||
], | ||
"images": [ | ||
"W5500-EVB-Pico2.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a nit, but wrong image? Should be "W5100S-EVB-Pico2.jpg"
?
"W5500-EVB-Pico2.jpg" | ||
], | ||
"mcu": "rp2350", | ||
"product": "Wiznet W5500-EVB-Pico2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a nit, but wrong product? Should be "Wiznet W5100S-EVB-Pico2"
?
|
||
// Enable networking. | ||
#define MICROPY_PY_NETWORK (1) | ||
#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "W5500S-EVB-PICO2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "W5500S-EVB-PICO2" | |
#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "W5100S-EVB-PICO2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello.
Thank you for pointing out my mistake.
I will add this to the commit. I truly appreciate it.
Best regards,
Grace
Signed-off-by: wiznet-grace <[email protected]>
I may be a bit confused, but are there remaining changes needed for this PR? Looking forward to getting this board supported! |
Sorry for the late reply, and thank you so much for your interest! This PR is still active and there are no pending changes at the moment. Thanks again for checking in — we really appreciate the support! |
Well, FWIW, I've been testing this PR in the wild. I picked up a W5100S-EVB-Pico2 a few weeks ago wth the add-on PoE module. I built a Micropython install for it using this PR and the v1.25 release tag. Flashed it and deployed my code on top. It has been running 24x7 monitoring a half dozen sensors every 10 seconds or so and sending the results over a TLS encrypted websocket to a central server. It seems pretty solid. Thanks for the work @wiznet-grace and I'm looking forward to this being merged. |
Thanks a lot for testing and sharing your results! Grace |
Hello ! any reason for not merging it yet? |
Hi, just following up on this PR. It’s been a few months since submission, I’d be happy to rebase or make any changes needed to get this merged. Let me know if there’s anything I can help with! Thanks again for maintaining MicroPython. cc @dpgeorge |
Hello @dpgeorge , This PR looks great, builds are passing and tests are conclusive, please advise on the reason of not approving yet. Thanks! @wiznet-grace can you please share the uf2 generated from this PR? or how to do it? would like to proceed cause 7 months are way too much for a PR 😄 |
Sure! You can generate the
Let me know if you need help flashing the .uf2 to your board 😄 |
Summary
This PR adds initial support for the W5500-EVB-PICO2 and W5100S-EVB-PICO2 boards.
The changes included in this PR are as follows:
These updates extend MicroPython's compatibility to additional RP2350-based boards, enabling more developers to utilize these platforms effectively.
Testing
W5500-EVB-PICO2 and W5100S-EVB-PICO2 boards successfully tested: