runtime/exitcodes: Set exit code according to the SystemExit exception. #15863
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpgeorge can you please have a look? It is the same code as last time. Can we merge it already? Is there something that blocks it, that I should change? This drags along for half a year or so already... |
|
Check commit message fails because of some other commit in the history not being signed off. This commit is OK and signed off |
|
Code size report: |
|
@dpgeorge, what do you think about this PR? |
|
@dpgeorge Hi, do you think you could find some time to review this case? Thank you |
13cccd3 to
07a0994
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15863 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 169 169
Lines 21968 21968
=======================================
Hits 21654 21654
Misses 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: John Smith <[email protected]>
07a0994 to
36f9a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add abort setup code (nlr_set_abort) to standard runtime. This makes the standard runtime respond to abort signal without any further modifications.
This PR continues previous PRs, originally at #14419 and later #15392 and #15730
Testing
Tested on ESP32, should work in other places. The changes are guarded by
#ifabort is enabled in the runtime -> only people who want the abort functionality will get this change.Trade-offs and Alternatives
This code may return non-zero exit code in scenarios where previous version did return zero exit code. The exit codes are configurable and the defaults are zero, so not to introduce any breaking changes.