Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebAPI] CSS Nesting - Make CSSStyleRule a CSSGroupingRule #28853

Closed
8 of 10 tasks
Tracked by #441
dipikabh opened this issue Aug 30, 2023 · 3 comments
Closed
8 of 10 tasks
Tracked by #441

[WebAPI] CSS Nesting - Make CSSStyleRule a CSSGroupingRule #28853

dipikabh opened this issue Aug 30, 2023 · 3 comments
Assignees
@hamishwillee
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@dipikabh
Copy link
Contributor

dipikabh commented Aug 30, 2023 •
edited by hamishwillee

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1846251

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if glossary updates are required for the feature you're documenting - whether an existing term needs to be updated or a new term should be added.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Aug 30, 2023
@dipikabh dipikabh added Content:CSS Cascading Style Sheets docs Firefox 118 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Aug 30, 2023
@dipikabh dipikabh mentioned this issue Aug 30, 2023
Closed
@Rumyra Rumyra changed the title [CSS] CSS Nesting - Make CSSStyleRule a CSSGroupingRule [WebAPI] CSS Nesting - Make CSSStyleRule a CSSGroupingRule Sep 1, 2023
@Rumyra Rumyra added the Content:WebAPI Web API docs label Sep 1, 2023
@hamishwillee hamishwillee self-assigned this Sep 18, 2023
@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 18, 2023 •
edited

This basically makes FF match the spec so CSSStyleRule inherits from CSSGroupingRule instead of directly from CSSRule.

The docs are all up to date. What is missing is that CSSStyleRule will now support the CSSGroupingRule properties cssRules, deleteRule, insertRule. The docs action here is to update BCD with links to those rules, and note they are supported in FF.

Status:

This was referenced Sep 18, 2023
Merged
Merged
@Rumyra Rumyra closed this as completed Sep 26, 2023
@Elchi3
Copy link
Member

Elchi3 commented Oct 18, 2023

See mdn/browser-compat-data#20928 (comment) this shipped in 117 apparently and not in 118.

See also https://hg.mozilla.org/mozilla-central/rev/62534bac9235 where it says: "(it's already enabled everywhere in 117)".

@hamishwillee hamishwillee mentioned this issue Oct 29, 2023
Merged
@hamishwillee
Copy link
Collaborator

Thanks very much @Elchi3. Glad you've got so much automation in the collector because I trusted the issue label. Fixed by #29891

@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 118 labels Jun 14, 2024
@danielzgtg danielzgtg mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishwillee hamishwillee

Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
MDN Web Docs Content Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Rumyra @Elchi3 @hamishwillee @dipikabh @bsmth