Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Accept Routes" toggle incorrect #36

Open
DuncanFairley opened this issue Aug 14, 2023 · 3 comments
Open

"Accept Routes" toggle incorrect #36

DuncanFairley opened this issue Aug 14, 2023 · 3 comments

Comments

@DuncanFairley
Copy link

Hi,
I had an existing Tailscale setup, with accept routes enabled.
My tailscale config had: "RouteAll": true,
I installed this extension.
In its initial state, it incorrectly listed "Accept Routes" as disabled.

I toggled it on. The config didn't change.
I toggled it off. The config did change.
I toggled it back on. The config did change.

I rebooted, and the extension is showing "Accept Routes" as disabled again, despite it still being enabled in /var/lib/tailscale/tailscaled.state.

Ubuntu 22.04.3
Tailscale 1.46.1.

@charles-997
Copy link

I am also having this same issue. I notice I need to re-select the "Accept Routes" toggle as enabled every time my computer resumes from sleep.

I think the Tailscale GUI Tray is not properly remembering the past toggle setting.

@WiteWulf
Copy link

Similar issue here with ubuntu 22.04.4 LTS and tailscale 1.64.0

With tailscale already connected, post-boot and login to machine:
Toggling "Accept routes" on and off in the UI has no effect.
Issuing "tailscale up --accept-routes=true" from the command line adds routes as expected.
Subsequently toggling "accept routes" in the UI adds and removes the routes as expected.

Log out of tailscale and back in again, with "Accept routes checked", routes are not added.
Toggle "accept routes" in UI has no effect.
Issuing "tailscale up --accept-routes=true" from the command line adds routes as expected.
Subsequently toggling "accept routes" in the UI adds and removes the routes as expected.

It seems that telling tailscale to accept routes from the command line is key, but that this is not preserved between tailscale login sessions.

@pdugas
Copy link

pdugas commented May 15, 2024

Wonder if it's because of this?

$ tailscale up --accept-routes=true
Error: changing settings via 'tailscale up' requires mentioning all
non-default flags. To proceed, either re-run your command with --reset or
use the command below to explicitly mention the current value of
all non-default settings:

	tailscale up --accept-routes --shields-up

May need to be smarter in the way the tailscale up commands are built. That appears to be the command run when that toggle is enabled. Ran it manually and got that. Ran the command with the --shields-up option and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants