-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add explicit **options: Any
for add_subplot
method
#30237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tially unknown type" warnings from type checkers like Pyright and Pylance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@GameRoMan Thank you for your contribution! Are you willing to do the backport to v3.10.x? The instructions are in the recent message from lumberbot-app. |
I'll see, If I'll have some time, I'll do that |
Add explicit
**options: Any
foradd_subplot
method to remove "partially unknown type" warnings from type checkers like Pyright and Pylance.Different option would be to add individually all options that this function accepts and their types, if that's better - I'll do that