Skip to content

Fix bug: undefined query when add new query after published app/module #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix bug: undefined query when add new query after published app/module
  • Loading branch information
dacbaohvktqs authored and ludomikula committed Jul 1, 2025
commit f743419583a2cef49f00641861c33c1b9ef918b4
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,20 @@ public boolean agencyProfile() {
}

public Mono<ApplicationQuery> getQueryByViewModeAndQueryId(boolean isViewMode, String queryId, ApplicationRecordService applicationRecordService) {
return getLiveQueries(applicationRecordService).map(liveQueries -> (isViewMode ? liveQueries : getEditingQueries())
.stream()
.filter(query -> queryId.equals(query.getId()) || queryId.equals(query.getGid()))
.findFirst()
.orElseThrow(() -> new BizException(BizError.QUERY_NOT_FOUND, "LIBRARY_QUERY_NOT_FOUND")));
return isViewMode ?
// Get Published Queries in View/View Marketplace Mode
getLiveQueries(applicationRecordService).map(liveQueries -> (liveQueries)
.stream()
.filter(query -> queryId.equals(query.getId()) || queryId.equals(query.getGid()))
.findFirst()
.orElseThrow(() -> new BizException(BizError.QUERY_NOT_FOUND, "LIBRARY_QUERY_NOT_FOUND")))
:
// Get Editing Queries in Edit/Preview Mode
Mono.just(getEditingQueries()
.stream()
.filter(query -> queryId.equals(query.getId()) || queryId.equals(query.getGid()))
.findFirst()
.orElseThrow(() -> new BizException(BizError.QUERY_NOT_FOUND, "LIBRARY_QUERY_NOT_FOUND")));
}

/**
Expand Down