Skip to content

Update Extension API #12805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Extension API #12805

wants to merge 1 commit into from

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 25, 2025 •
edited
Loading

Motivation

With #9194, we introduced the concept of Finalizers.
Those are not yet available in Extensions.
This PR adds that 😄

note: naming can be updated, but all the methods ending with _handlers were accessing a Composite*Handler, but the finalizers are defined as CompositeFinalizer with no handler in the name, so I followed the same convention.

Changes

  • update the signature of the Extension base class

@bentsku bentsku added this to the Playground milestone Jun 25, 2025
@bentsku bentsku self-assigned this Jun 25, 2025
@bentsku bentsku added the semver: patch Non-breaking changes which can be included in patch releases label Jun 25, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 727 tests  ±0   20 070 ✅ ±0   6m 10s ⏱️ -4s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fc7bf4a. ± Comparison against base commit 25552f2.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fc7bf4a. ± Comparison against base commit 25552f2.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 44s ⏱️
5 251 tests 4 325 ✅ 926 💤 0 ❌
5 257 runs  4 325 ✅ 932 💤 0 ❌

Results for commit fc7bf4a.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 33s ⏱️ - 3m 41s
4 894 tests ±0  4 120 ✅ ±0  774 💤 ±0  0 ❌ ±0 
4 896 runs  ±0  4 120 ✅ ±0  776 💤 ±0  0 ❌ ±0 

Results for commit fc7bf4a. ± Comparison against base commit 25552f2.

@bentsku bentsku marked this pull request as ready for review June 26, 2025 09:20
@bentsku bentsku requested a review from thrau as a code owner June 26, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau Awaiting requested review from thrau thrau is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bentsku bentsku

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
1 participant
@bentsku