Skip to content

Fix logging placeholder for apigateway openapi import #12800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Fix logging placeholder for apigateway openapi import #12800

merged 1 commit into from
Jun 26, 2025

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jun 25, 2025

Motivation

We got alerted that there is a missing placeholder for our apigateway logging for importing openapi specs.

Changes

  • Fix log format string

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jun 25, 2025
@dfangl dfangl self-assigned this Jun 25, 2025
bentsku
bentsku approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! Probably some code we'd need to look at more generally at some point 👀 if it's even real or not. Thanks for fixing!

cloutierMat
cloutierMat approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🚀

@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 727 tests  ±0   20 070 ✅ ±0   6m 17s ⏱️ +6s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fd2b268. ± Comparison against base commit 3d56935.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fd2b268. ± Comparison against base commit 3d56935.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   20m 22s ⏱️ - 1h 24m 28s
1 137 tests  - 3 757  1 072 ✅  - 3 048  65 💤  - 709  0 ❌ ±0 
1 139 runs   - 3 757  1 072 ✅  - 3 048  67 💤  - 709  0 ❌ ±0 

Results for commit fd2b268. ± Comparison against base commit 3d56935.

This pull request removes 3757 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   35m 43s ⏱️
1 161 tests 1 096 ✅ 65 💤 0 ❌
1 167 runs  1 096 ✅ 71 💤 0 ❌

Results for commit fd2b268.

@dfangl dfangl merged commit 21b3a06 into master Jun 26, 2025
42 checks passed
@dfangl dfangl deleted the apigateway/helper-log-placeholder branch June 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfangl @bentsku @cloutierMat