Skip to content

CFNv2: implement get_template_summary #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

CFNv2: implement get_template_summary #12784

merged 2 commits into from
Jun 27, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Jun 22, 2025 •
edited
Loading

Motivation

The new CloudFormation engine does not yet support get_template_summary, which is required for parity with the old provider.

Changes

  • Adds Type field to ResolvedResource
  • Adds is_active helper method to the Stack type, removing the helper method call from the provider
  • Implements the provider method, including summarising templates from stacks or from URLs/bodies
  • Unskips two tests

@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases labels Jun 22, 2025
@simonrw simonrw force-pushed the cfn/v2/implement-get-template-summary branch from 88919e1 to eb7ec67 Compare June 22, 2025 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 727 tests  ±0   20 070 ✅ ±0   6m 18s ⏱️ ±0s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 2df8f3f. ± Comparison against base commit 62f162f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -13s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2df8f3f. ± Comparison against base commit 62f162f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 24s ⏱️ + 1m 14s
4 896 tests +2  4 122 ✅ +2  774 💤 ±0  0 ❌ ±0 
4 898 runs  +2  4 122 ✅ +2  776 💤 ±0  0 ❌ ±0 

Results for commit 2df8f3f. ± Comparison against base commit 62f162f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 23m 19s ⏱️ + 3m 30s
5 253 tests +2  4 327 ✅ +2  926 💤 ±0  0 ❌ ±0 
5 259 runs  +2  4 327 ✅ +2  932 💤 ±0  0 ❌ ±0 

Results for commit 2df8f3f. ± Comparison against base commit 62f162f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Test Results - Alternative Providers

988 tests  ±0   622 ✅ +1   34m 19s ⏱️ -10s
  4 suites ±0   365 💤  - 2 
  4 files   ±0     1 ❌ +1 

For more details on these failures, see this check.

Results for commit eb7ec67. ± Comparison against base commit 7dffb23.

Base automatically changed from cfn/v2/implement-create-stack to master June 23, 2025 11:31
@simonrw simonrw force-pushed the cfn/v2/implement-get-template-summary branch from eb7ec67 to 1861889 Compare June 24, 2025 22:29
@simonrw
Implement get_template_summary
4344303 
At least an initial version that matches one test
@simonrw simonrw force-pushed the cfn/v2/implement-get-template-summary branch from 1861889 to 4344303 Compare June 24, 2025 22:35
@simonrw simonrw marked this pull request as ready for review June 26, 2025 11:34
@simonrw simonrw requested a review from MEPalma June 26, 2025 11:34
@simonrw simonrw merged commit 5b0180c into master Jun 27, 2025
39 checks passed
@simonrw simonrw deleted the cfn/v2/implement-get-template-summary branch June 27, 2025 05:16
@simonrw simonrw added this to the 4.6 milestone Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MEPalma MEPalma MEPalma approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees
No one assigned
Labels
aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @MEPalma