Skip to content

removed create appsync fixtures #12572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

removed create appsync fixtures #12572

merged 1 commit into from
Jul 2, 2025

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented May 1, 2025

Motivation

This fixture was moved upstream as the underlying resources can't be deployed in the community version of LocalStack

Changes

  • Delete appsync_create_api fixture

Testing

External run number: 15783613172 🟢

@cloutierMat cloutierMat added semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted labels May 1, 2025
Copy link

github-actions bot commented May 1, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 22s ⏱️ - 1m 3s
4 890 tests ±0  4 116 ✅ ±0  774 💤 ±0  0 ❌ ±0 
4 892 runs  ±0  4 116 ✅ ±0  776 💤 ±0  0 ❌ ±0 

Results for commit 282fc2d. ± Comparison against base commit 6348947.

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat added this to the 4.5 milestone May 6, 2025
@anisaoshafi
Copy link
Contributor

@cloutierMat Just checking if this is going to make it to release 4.5. Otherwise, please update the milestone to 4.6 or playground. Thanks.

@cloutierMat cloutierMat modified the milestones: 4.5, 4.6 Jun 4, 2025
@cloutierMat cloutierMat force-pushed the remove-unused-fixture branch from a8a2cc0 to 282fc2d Compare June 20, 2025 16:39
Copy link

Test Results - Preflight, Unit

21 635 tests  ±0   19 978 ✅ ±0   6m 11s ⏱️ -3s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 282fc2d. ± Comparison against base commit 6348947.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 282fc2d. ± Comparison against base commit 6348947.

Copy link

Test Results - Alternative Providers

988 tests   621 ✅  34m 26s ⏱️
  4 suites  367 💤
  4 files      0 ❌

Results for commit 282fc2d.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 47s ⏱️
5 247 tests 4 321 ✅ 926 💤 0 ❌
5 253 runs  4 321 ✅ 932 💤 0 ❌

Results for commit 282fc2d.

@cloutierMat cloutierMat marked this pull request as ready for review June 20, 2025 18:54
@baermat
Copy link
Member

baermat commented Jul 1, 2025

@cloutierMat If this PR needs a milestone bumb again, please do so :)

@cloutierMat
Copy link
Contributor Author

@baermat This PR is only removing a fixture that is no longer used. Test suite was executed against ext to validate no tests are relying on it.

Can I ask you for a quick review and a merge? 🙏

@baermat baermat merged commit fdef993 into master Jul 2, 2025
45 checks passed
@baermat baermat deleted the remove-unused-fixture branch July 2, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants