gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

at055612 · 2025-03-06T16:12:27Z

Fixes #249

There are now essentially three ways of configuring comparators when creating a Dbi.

null comparator
LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key.

provided comparator
LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key.

provided comparator with nativeCb==true
LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key.

The methods getSignedComparator() and getUnsignedComparator() have been made public so users of this library can access them.

There are now essentially three ways of configuring comparators when creating a Dbi. **null comparator** LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key. **provided comparator** LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key. **provided comparator with nativeCb==true** LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key. The methods `getSignedComparator()` and `getUnsignedComparator()` have been made public so users of this library can access them.

codecov · 2025-03-06T16:15:59Z

Codecov Report

Attention: Patch coverage is 59.52381% with 68 lines in your changes missing coverage. Please review.

Project coverage is 86.75%. Comparing base (154df33) to head (620a89f).

Files with missing lines	Patch %	Lines
src/main/java/org/lmdbjava/DbiBuilder.java	0.00%	60 Missing ⚠️
src/main/java/org/lmdbjava/Key.java	73.68%	4 Missing and 1 partial ⚠️
src/main/java/org/lmdbjava/CursorIterable.java	95.00%	2 Missing ⚠️
src/main/java/org/lmdbjava/Env.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     88.25%   86.75%   -1.50%     
- Complexity      408      415       +7     
============================================
  Files            32       34       +2     
  Lines          1456     1563     +107     
  Branches        124      136      +12     
============================================
+ Hits           1285     1356      +71     
- Misses          101      138      +37     
+ Partials         70       69       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/main/java/org/lmdbjava/KeyRangeType.java

src/test/java/org/lmdbjava/CursorIterablePerfTest.java

+            cnt++;
+          }
+        }
+        final Duration duration = Duration.between(start, Instant.now());


src/test/java/org/lmdbjava/CursorIterableTest.java

+      populateList();
+      try (Txn<ByteBuffer> txn = env.txnRead();
+          CursorIterable<ByteBuffer> c = db.iterate(txn)) {
+


src/test/java/org/lmdbjava/CursorIterableTest.java

+
+      try (Txn<ByteBuffer> txn = env.txnRead();
+           CursorIterable<ByteBuffer> c = db.iterate(txn, keyRange)) {
+        for (final CursorIterable.KeyVal<ByteBuffer> kv : c) {
