Skip to content

Update web_color.cpp #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update web_color.cpp #405

wants to merge 1 commit into from

Conversation

twardoch
Copy link

Update web_color.cpp as it was causing segfaults

Update web_color.cpp as it was causing segfaults
@tordex
Copy link
Member

tordex commented May 11, 2025

@twardoch, please could you provide an example with segfault that this commit fixes?

@twardoch
Copy link
Author

Well, I’ve vibe-coded an app https://github.com/twardoch/qlith which now works but was failing with the unpatched version of litehtml — but it’s hard for me to give any details, because I used Claude Sonnet to fix the issue.

@tordex
Copy link
Member

tordex commented May 11, 2025

Well, I've looked at your vibe-coded app. The issue in your container container_qt5::resolve_color. It must return empty string in case of color name is not resolved. Your function returns the input argument (color) when resolve is failed. So you get infinite recursion.

Sorry, I can't accept your PR. Just fix your container.

@tordex tordex closed this May 11, 2025
@twardoch
Copy link
Author

Thanks for taking the time to review :) I mainly needed a prototype for Qt integration, and I have one working now. Two orders of magnitude savings for an HTML renderer is nice (LiteHTML takes ~3 MB while QWebEngine is 150 MB+), and LiteHTML’s conformance does look decent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants