media_query: add match for screen #404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nevermind, after trying in litebrowser-linux (following advice in #359), this is already properly working. I did not implement In it, you set the |
|
Specifically, this kind of line is what I was missing, in the class that implements document_container: litehtml/containers/cairo/container_cairo.cpp Line 652 in 2d34cb9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #359, to match media queries that specify
screentype (as opposed toprint), such as Wikipedia.According to the linked media queries doc,
screenshould be:And
printis:So either one or the other should be matched. Screenshots and example HTML are in the original issue (#359).