Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix checking return value of the evdns_base_resolv_conf_parse()
Reported-by: Maxim Gorbachyov <[email protected]> (cherry picked from commit c3f3534)
- Loading branch information
fc51bf2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, this change slightly broke Transmission:
transmission/transmission#1437
fc51bf2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olysonek thanks for reporting this, however the problem is in transmission code, not libevent itself
fc51bf2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azat I'm considering temporarily reverting the libevent change downstream in Fedora until Transmission is fixed. Do you see any issues this could cause?
Thanks!
fc51bf2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to revert it, this should not cause any problems in other places (except for not returning error when it should)