Skip to content

Remove alpha environment variable because feature is in beta #42907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove alpha environment variable because feature is in beta #42907

merged 1 commit into from
Nov 9, 2023

Conversation

ardaguclu
Copy link
Member

Since kubernetes/enhancements#3895 has been promoted to beta, environment
variable representing alpha feature enablement has become obsolete. This PR removes this from website.

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 6, 2023
@netlify
Copy link

netlify bot commented Sep 6, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d26e66d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64f816aa579ae80009b63cca

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2023
This was referenced Sep 6, 2023
Closed
Closed
@Shubham82
Copy link
Contributor

put on hold until the following PRs will merge:
k8s/k8s#120416 and k8s/enhancements#4178.

/hold

Please remove the hold label once the above PR is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@sftim
Copy link
Contributor

sftim commented Sep 6, 2023

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Sep 6, 2023
@tengqm tengqm changed the title Remove alpha environment variable because feature is in beta WIP - Remove alpha environment variable because feature is in beta Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@ardaguclu ardaguclu changed the title WIP - Remove alpha environment variable because feature is in beta Remove alpha environment variable because feature is in beta Oct 23, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@ardaguclu
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@Princesso
Copy link
Contributor

Princesso commented Oct 30, 2023 •
edited
Loading

Hello @ardaguclu 👋, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@Princesso
Copy link
Contributor

Hello @ardaguclu 👋, gebtle reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@ardaguclu
Copy link
Member Author

@Princesso thanks for your message. But I think, my PR is ready for review. What am I missing?.

@Princesso
Copy link
Contributor

Thanks @ardaguclu for the update, I didn't take cognisance of that and this is a general update for unmerged PRs. Again, thanks for the update.

@ardaguclu
Copy link
Member Author

@bradtopol @tengqm could you PTAL?. Thanks.

@tengqm
Copy link
Contributor

tengqm commented Nov 9, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@Princesso
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 819c58f66889213be5c7418a3e53e98af8fe28f8

@k8s-ci-robot k8s-ci-robot merged commit fff0693 into kubernetes:dev-1.29 Nov 9, 2023
@ardaguclu ardaguclu deleted the kep-3895-promote-beta branch November 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@Princesso Princesso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG CLI
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@ardaguclu @Shubham82 @sftim @Princesso @tengqm @k8s-ci-robot