Skip to content

pull-kubernetes-node-swap-ubuntu-serial to run with cgroup v2 #30297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

pull-kubernetes-node-swap-ubuntu-serial to run with cgroup v2 #30297

merged 1 commit into from
Aug 8, 2023

Conversation

iholder101
Copy link
Contributor

Since in Beta1 NodeSwap does not support cgroup v1, pull-kubernetes-node-swap-ubuntu-serial should be using cgroup v2. See kubernetes/kubernetes#118764 for more info.

This PR is a pre-requisite for kubernetes/kubernetes#119327, which aims to fail kubelet when swap is being used with cgroup v1. As of now, jobs like pull-kubernetes-node-swap-ubuntu-serial fail instantly with this PR since they use cgroup v1. With this PR merged, I wish all tests would pass with the above PR.

Fixes kubernetes/kubernetes#119726

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 6, 2023
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and pacoxu August 6, 2023 10:48
@iholder101 iholder101 force-pushed the ubuntu-swap/set-cgroupv2 branch from d05a838 to bcebc0f Compare August 6, 2023 10:49
@iholder101 iholder101 mentioned this pull request Aug 6, 2023
Closed
2 tasks
@iholder101 iholder101 changed the title Make pull-kubernetes-node-swap-ubuntu-serial run with cgroup v2 pull-kubernetes-node-swap-ubuntu-serial to run with cgroup v2 Aug 6, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 6, 2023

/cc @SergeyKanzhelev

SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@iholder101
Copy link
Contributor Author

/test pull-test-infra-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 6ca5f43 into kubernetes:master Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

@iholder101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Since in Beta1 NodeSwap does not support cgroup v1, pull-kubernetes-node-swap-ubuntu-serial should be using cgroup v2. See kubernetes/kubernetes#118764 for more info.

This PR is a pre-requisite for kubernetes/kubernetes#119327, which aims to fail kubelet when swap is being used with cgroup v1. As of now, jobs like pull-kubernetes-node-swap-ubuntu-serial fail instantly with this PR since they use cgroup v1. With this PR merged, I wish all tests would pass with the above PR.

Fixes kubernetes/kubernetes#119726

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kannon92 kannon92 mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt swap jobs to run with cgroup v2
4 participants
@iholder101 @bart0sh @k8s-ci-robot @SergeyKanzhelev