Skip to content

scheduler_perf: Fix version emulation for empty featureGates map #132623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

scheduler_perf: Fix version emulation for empty featureGates map #132623

wants to merge 1 commit into from
+1 −1

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 30, 2025

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

  • Tests with SchedulerQueueingHints: false → v1.33 emulation (intended behavior)
  • Tests with SchedulerQueueingHints: true → No emulation (can use v1.34+ features)
  • Tests without QueueingHints setting → No emulation (fixed in this PR

Which issue(s) this PR is related to:

Fixes #132482

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from AxeZhan and damemi June 30, 2025 12:36
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 30, 2025
@utam0k
Copy link
Member Author

utam0k commented Jun 30, 2025

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho June 30, 2025 12:37
@macsko
Copy link
Member

macsko commented Jul 1, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@damemi damemi Awaiting requested review from damemi

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler_perf: Set version emulation only when QueueingHints is disabled
3 participants
@utam0k @k8s-ci-robot @macsko