Skip to content

scheduler_perf: add logs to report the failure of measuring Schedulin… #132619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

scheduler_perf: add logs to report the failure of measuring Schedulin… #132619

wants to merge 2 commits into from

Conversation

saza-ku
Copy link
Contributor

@saza-ku saza-ku commented Jun 30, 2025

What type of PR is this?

/kind feature
/sig-scheduling

What this PR does / why we need it:

scheduler_perf sometimes fails to record SchedulingThroughput. The cause is that the scenario doesn't have enough pods and nodes to take more than throughputSampleInterval (i.e. 1 sec) and throughputCollector collects no record.

In the current implementation it reports nothing when this issue occurs, so users of scheduler_perf wouldn't know why SchedulingThroughput is not recorded. This PR avoids such a situation by logging that the scenario lacks the number of pods and nodes.

Which issue(s) this PR is related to:

#132188

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @saza-ku. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from denkensk and macsko June 30, 2025 09:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saza-ku
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Jun 30, 2025

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho June 30, 2025 09:13
utam0k
utam0k reviewed Jun 30, 2025
View reviewed changes
test/integration/scheduler_perf/util.go
// tc.schedulingThroughputs can be empty if the scenario doesn't have
// enough number of pods and nodes to take more than throughputSampleInterval (i.e. 1 second).
if throughputSummary.Data == nil {
klog.Warningf("Failed to measure SchedulingThroughput for %s. The scenario needs to have enough pods and nodes to take more than 1 second.", tc.resultLabels["Name"])
Copy link
Member

@utam0k utam0k Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
klog.Warningf("Failed to measure SchedulingThroughput for %s. The scenario needs to have enough pods and nodes to take more than 1 second.", tc.resultLabels["Name"])
klog.Warningf("Failed to measure SchedulingThroughput for %s. The scenario needs to have enough pods and nodes to take more than %s.", tc.resultLabels["Name"], throughputSampleInterval,)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k left review comments

@denkensk denkensk Awaiting requested review from denkensk

@macsko macsko Awaiting requested review from macsko

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees
No one assigned
Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saza-ku @k8s-ci-robot @pacoxu @utam0k