Commonize filtering of Pods by Owner with all orphans in namespace #132615
+30
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/sig apps |
|
LGTM. |
|
/cc @wojtek-t |
|
/lgtm Thanks @mimowo |
|
LGTM label has been added. Git tree hash: 1c94a333d2b70694ed6187acec26169e0641cba1
|
atiratree
reviewed
Jul 1, 2025
| result := []*v1.Pod{} | ||
| // Iterate over two keys: | ||
| // - the UID of the owner, which identifies Pods that are controlled by the owner | ||
| // - the OrphanPodIndexKey, which identifies orphaned Pods in the owner's namespace |
There was a problem hiding this comment.
Suggested change
| // - the OrphanPodIndexKey, which identifies orphaned Pods in the owner's namespace | |
| // - the OrphanPodIndexKey, which identifies orphaned Pods in the owner's namespace and might be adopted by the owner later |
| @@ -1112,6 +1113,29 @@ func AddPodControllerUIDIndexer(podInformer cache.SharedIndexInformer) error { | |||
| }) | |||
| } | |||
|
|
|||
| // FilterPodsByOwner gets the Pods managed by an owner or orphan Pods in the owner's namespace | |||
| func FilterPodsByOwner(podIndexer cache.Indexer, owner *metav1.ObjectMeta) ([]*v1.Pod, error) { | |||
There was a problem hiding this comment.
Can we take this refactoring as an opportunity to introduce a simple unit test?
|
/triage accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
DRY principle, as part of #130767
Which issue(s) this PR is related to:
Special notes for your reviewer:
The duplication was observed when solving subtle issues in previous PR
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: