The committers listed above are authorized under a signed CLA.

• ✅ login: mahmoudaboueleneen / name: Mahmoud Abou Eleneen (eb89f97, ca9d4bb)

Welcome @mahmoudaboueleneen!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Hi @mahmoudaboueleneen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mahmoudaboueleneen
Once this PR has been reviewed and has the lgtm label, please assign yujuhong for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

/ok-to-test

/cc @natasha41575

@mahmoudaboueleneen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

I tried this approach (rewriting the constructor of the allocation manager) to solve the circular dependency problem; however, it may not be the best solution. Your PR (eb89f97) didn't rewrite related test files, and there are tons of usages related to kubelet initialization (which use custom admitHandlers or not to initialize the allocationManager) in those test files. Applying changes to ALL related test files would create an XXL PR, much bigger than the current one.

@ylink-lfs I see, thank you for the insight. Do you have any suggestions as to how to proceed?

@ylink-lfs I see, thank you for the insight. Do you have any suggestions as to how to proceed?

I raised an implementation plan discussion waiting for maintainers'suggestion in the related issue

@ylink-lfs I see, thank you for the insight. Do you have any suggestions as to how to proceed?

I raised an implementation plan discussion waiting for maintainers'suggestion in the related issue

Alright, should I close this PR and attempt another issue? Seems a bit big for a good first issue

@ylink-lfs I see, thank you for the insight. Do you have any suggestions as to how to proceed?

I raised an implementation plan discussion waiting for maintainers'suggestion in the related issue

Alright, should I close this PR and attempt another issue? Seems a bit big for a good first issue

It may be a good-second-issue. Harder than deprecation utilities replacement and coverage-driven works definitely.