-
Notifications
You must be signed in to change notification settings - Fork 40.9k
[PodLevelResources] Add more comprehensive test cases to kubelet #132601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @toVersus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: toVersus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -165,7 +165,7 @@ func podLevelResourcesTests(f *framework.Framework) { | |||
|
|||
tests := []testCase{ | |||
{ | |||
name: "Guaranteed QoS pod with container resources", | |||
name: "Guaranteed QoS pod with only container resources", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this because it was duplicated with the test case name at l.188.
name: "Guaranteed QoS pod with container resources", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this and also for the PR :)
/cc @ndixita |
Signed-off-by: Tsubasa Nagasawa <[email protected]>
027447e
to
dddda58
Compare
/ok-to-test |
{Failed === RUN TestStreamTranslator_BlockRedirects
streamtranslator_test.go:828: expected redirect not allowed error, got (closed all streams)
--- FAIL: TestStreamTranslator_BlockRedirects (0.06s)
}
{Failed === RUN TestEviction/add
=== PAUSE TestEviction/add
=== CONT TestEviction/add
(...)
device_taint_eviction_test.go:1378: FATAL ERROR:
Timed out after 30.007s.
pod evicted
device_taint_eviction_test.go:1356: Waiting for goroutine termination...
--- FAIL: TestEviction/add (30.05s)
=== RUN TestEviction
=== PAUSE TestEviction
=== CONT TestEviction
--- FAIL: TestEviction (0.13s)
} /retest |
/test pull-kubernetes-unit
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Added comprehensive test cases to the kubelet unit tests and node E2E tests. For the node E2E tests, I've added test cases based on the table in the Comprehensive Tabular View section of the PodSpec Validation Rules in the KEP.
Which issue(s) this PR is related to:
KEP: kubernetes/enhancements#2837
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: